Move swss-common/swss-common-testing to sonic-swss-common repo#86
Merged
r12f merged 4 commits intosonic-net:masterfrom Jul 21, 2025
Merged
Move swss-common/swss-common-testing to sonic-swss-common repo#86r12f merged 4 commits intosonic-net:masterfrom
r12f merged 4 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jul 18, 2025
Collaborator
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
Signed off the swss-common PR, hence sign off here as well. Feel free to merge, once the branch name is updated :D.
Also prefer to use commit ID to lock a specific version.
r12f
approved these changes
Jul 18, 2025
Collaborator
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
Signed off the swss-common PR, hence sign off here as well. Feel free to merge, once the branch name is updated :D.
Also prefer to use commit ID to lock a specific version.
crates/container/Cargo.toml
Outdated
| futures-util = { workspace = true } | ||
| clap = { workspace = true } | ||
| swss-common = { path = "../swss-common" } | ||
| swss-common = { git = "https://github.com/qiluo-msft/sonic-swss-common.git", branch = "qiluo/rustcrate" } |
Collaborator
There was a problem hiding this comment.
prefer to also add a commit id.
Collaborator
There was a problem hiding this comment.
cargo.lock has it covered now. great!
Collaborator
There was a problem hiding this comment.
cargo lock seems to be missing, will be great to add. otherwise dependency can easily break build. #Resolved
Contributor
Author
There was a problem hiding this comment.
added Cargo.lock
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
added a commit
to mssonicbld/sonic-swss-common.msft
that referenced
this pull request
Jul 31, 2025
…onic-net/sonic-dash-ha Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha After this PR, remove code in sonic-net/sonic-dash-ha#86
mssonicbld
added a commit
to Azure/sonic-swss-common.msft
that referenced
this pull request
Jul 31, 2025
…onic-net/sonic-dash-ha (#49) Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha After this PR, remove code in sonic-net/sonic-dash-ha#86
|
Cherry-pick PR to msft-202506: Azure/sonic-dash-ha.msft#8 |
mssonicbld
added a commit
to mssonicbld/sonic-swss-common.msft
that referenced
this pull request
Sep 10, 2025
…onic-net/sonic-dash-ha Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha After this PR, remove code in sonic-net/sonic-dash-ha#86
mssonicbld
added a commit
to Azure/sonic-swss-common.msft
that referenced
this pull request
Sep 10, 2025
…onic-net/sonic-dash-ha (#62) Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha After this PR, remove code in sonic-net/sonic-dash-ha#86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only merge this PR after merging sonic-net/sonic-swss-common#1052